Skip to content

build: depend on the published crates.io canokey-c crate - #6

Merged
dangfan merged 1 commit into
masterfrom
chore/canokey-c-crates-io
Sep 23, 2026
Merged

build: depend on the published crates.io canokey-c crate#6
dangfan merged 1 commit into
masterfrom
chore/canokey-c-crates-io

Conversation

@dangfan

@dangfan dangfan commented Sep 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Replace the libcanokey Git revision pin (b709b3d) with the published canokey-c 0.1.0 crate from crates.io. The published C ABI header is byte-identical to the pinned revision, and the full macOS Debug build plus all 12 CTest contracts pass with the crates.io source.

Cargo.lock now records the crates.io registry checksum for canokey-c and its sibling canokey-* crates. Update the build documentation in README, architecture.md, AGENTS.md, and the libcanokey.cmake comment to describe the crates.io dependency instead of the Git pin.

Summary by CodeRabbit

  • Build & Compatibility

    • Updated the Rust integration to use the published canokey-c release, providing a consistent dependency source while preserving existing PIV feature support.

  • Documentation

    • Updated build instructions and architecture documentation to reflect the current dependency source and clarify dependency versioning.

@dangfan
build: depend on the published crates.io canokey-c crate
d41a330 
Replace the libcanokey Git revision pin (b709b3d) with the published
canokey-c 0.1.0 crate from crates.io. The published C ABI header is
byte-identical to the pinned revision, and the full macOS Debug build
plus all 12 CTest contracts pass with the crates.io source.

Cargo.lock now records the crates.io registry checksum for canokey-c and
its sibling canokey-* crates. Update the build documentation in README,
architecture.md, AGENTS.md, and the libcanokey.cmake comment to describe
the crates.io dependency instead of the Git pin.

Signed-off-by: Fan DANG <i@dang.fan>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 12d37294-23f7-4d65-b60b-b0a6948a90c4

📥 Commits

Reviewing files that changed from the base of the PR and between 106f77f and d41a330.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • AGENTS.md
  • Cargo.toml
  • README.md
  • cmake/libcanokey.cmake
  • docs/architecture.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The Rust dependency changes from a pinned Git revision to the published crates.io canokey-c 0.1.0 release. Build comments and project documentation now describe the published dependency.

Changes

Published canokey-c dependency

Layer / File(s) Summary
Dependency source and documentation alignment
Cargo.toml, cmake/libcanokey.cmake, AGENTS.md, README.md, docs/architecture.md		 Cargo.toml uses crates.io canokey-c 0.1.0 with the existing feature settings. Build comments and documentation now describe the published dependency instead of the pinned Git revision. No CMake build logic changed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: harry-chen

Merge Risk: ⚪ Minimal · up to d41a3

The published dependency is documented and no merge-blocking behavior is evidenced.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: replacing the pinned Git dependency with the published crates.io canokey-c crate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dangfan
dangfan merged commit 118f024 into master Sep 23, 2026
12 checks passed
@dangfan
dangfan deleted the chore/canokey-c-crates-io branch September 23, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dangfan